Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support web standard crypto.subtle #21580

Closed
MichaelJCole opened this issue Jun 28, 2018 · 6 comments
Closed

Please support web standard crypto.subtle #21580

MichaelJCole opened this issue Jun 28, 2018 · 6 comments
Labels
crypto Issues and PRs related to the crypto subsystem. duplicate Issues and PRs that are duplicates of other issues or PRs. feature request Issues that request new features to be added to Node.js.

Comments

@MichaelJCole
Copy link

MichaelJCole commented Jun 28, 2018

Node.js developed it's own crypto API before the WebCrypto API.

Since then, browsers and the web have standardized implementations around the WebCrypto API standard.

This bug is about Node.js missing support for the WebCrypto standard API and reopens #2833 (from 2015).

Asking 3rd party libraries to implement the WebCrypto standard is not responsible from a security standpoint for a variety of reasons from implementation expertise to malware. It is not responsible to put this onto API end users (developers).

Additionally, a variety of implementation differences (like this one) make compatible implementations buggy and error-prone.

Back in 2015, there were arguments for not supporting the WebCrypto standard in Node 0.12.

Today, committing to not supporting the WebCrypto standard is committing to a lack of responsibility for Nodejs as a secure and standards based platform on the web.

@devsnek devsnek added crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js. labels Jun 28, 2018
@bnoordhuis bnoordhuis added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jun 28, 2018
@bnoordhuis
Copy link
Member

Largely a duplicate of #19826 from earlier this year. The answer is still 'no'.

Places where gaps in the existing crypto API make emulating WebCrypto hard can be taken into consideration. Asking for WebCrypto to be added to core verbatim? Not on the table.

@MichaelJCole

This comment has been minimized.

@bnoordhuis

This comment has been minimized.

@MichaelJCole

This comment has been minimized.

@bnoordhuis

This comment has been minimized.

@nodejs nodejs locked as too heated and limited conversation to collaborators Jun 29, 2018
@ryanmurakami
Copy link
Contributor

Locking the conversation. I don't see this conversation becoming productive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crypto Issues and PRs related to the crypto subsystem. duplicate Issues and PRs that are duplicates of other issues or PRs. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

4 participants