Incorrect module path resolving with NODE_PATH in Windows

[tamtakoe]

Windows 8.1, io.js 3.0.0

test
|- lib
   |- module.js
|- index.js

NODE_PATH = D:\Projects\test

index.js:

console.log(require.resolve('./lib/module'));
console.log(require.resolve('lib/module'));

So I get different paths:

d:\Projects\test\lib\module.js
D:\Projects\test\lib\module.js

if NODE_PATH = d:\Projects\test (lowercased disk letter) all is ok:

d:\Projects\test\lib\module.js
d:\Projects\test\lib\module.js

[seishun]

sigh I thought we got rid of lowercasing drive letters.

[seishun]

I'm unable to reproduce this issue on Node.js v4.2.1. Can you?

[Jokero]

@seishun Problem can be reproduced. I do it on nodejs 5.5.0.

D:\Programming\test>node

> process.env.NODE_PATH
'd:\\Programming\\test'

And result:

D:\Programming\test>node index.js

D:\Programming\test\lib\module.js
d:\Programming\test\lib\module.js

[seishun]

I'm not sure if it's a bug. It uses the NODE_PATH variable when you call require.resolve('lib/module') and uses it as-is without changing cases.

[Jokero]

Resolved with and without NODE_PATH paths must be the same. It's expected behaviour

[seishun]

I disagree. The paths definitely don't generally have to be the same, since NODE_PATH could point to a different directory and resolve to a different file.

Consider a more obvious example: let's say NODE_PATH involves symlinks. In that case, one would expect require.resolve to return the path that was actually followed, rather than the real path. Letter casing is similar to symlinks in the sense that different paths point to the same physical file.

cc @nodejs/collaborators other opinions?

[mcollina]

Apart from different strings, what problems does this cause?

It's not generically wrong or right. Also, it is not expected: you can have the same issue on OS X.

[seishun]

Proposing to close this.