Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node debug fails if 'cont' entered while connecting #3168

Closed
serprex opened this issue Oct 3, 2015 · 5 comments
Closed

node debug fails if 'cont' entered while connecting #3168

serprex opened this issue Oct 3, 2015 · 5 comments

Comments

@serprex
Copy link

serprex commented Oct 3, 2015

node debug main.js
cont
connecting to 127.0.0.1:5858 ..cont
... ok
< Debugger listening on port 5858
break in main.js:2
debug> cont
There was an internal error in Node's debugger. Please report this bug.
Cannot read property 'split' of undefined
TypeError: Cannot read property 'split' of undefined
at _debugger.js:1094:27
at Client._onResponse (_debugger.js:249:5)
at Protocol.execute (_debugger.js:120:14)
at Client. (_debugger.js:159:14)
at emitOne (events.js:77:13)
at Client.emit (events.js:169:7)
at readableAddChunk (_stream_readable.js:146:16)
at Client.Readable.push (_stream_readable.js:110:10)
at TCP.onread (net.js:523:20)

@mscdex mscdex added the debugger label Oct 3, 2015
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

is this still an issue?
ping @nodejs/collaborators ... can anyone confirm this?

@thefourtheye
Copy link
Contributor

I just tried this on the local latest master

< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in /home/thefourtheye/Desktop/Test.js:1
> 1 var assert = require('assert');
  2 
  3 function X(msg) {
debug> cont
debug> process.versions
{ http_parser: '2.6.2',
  node: '6.0.0-pre',
  v8: '4.9.385.27',
  uv: '1.8.0',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '47',
  openssl: '1.0.2g' }

@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

Looks possibly like an odd timing edge case perhaps. I'm unable to reproduce at all.

@serprex
Copy link
Author

serprex commented Apr 2, 2016

I'm still able to cause this error with 5.10.0. I'm on a slow computer; you may have luck with a large main.js

Here's a more recent stack trace. Notice that I enter cont twice. The first time the prompt stalls on a blank line, where I can press Enter to resume, but if I enter cont again..:

node debug server.js
cont
debug> cont
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 .... ok
break in server.js:2
cont
There was an internal error in Node's debugger. Please report this bug.
Cannot read property 'split' of undefined
TypeError: Cannot read property 'split' of undefined
    at _debugger.js:1097:27
    at Client.__dirname.Client.Client._onResponse (_debugger.js:249:5)
    at Protocol.Client.protocol.onResponse (_debugger.js:162:39)
    at Protocol.execute (_debugger.js:120:14)
    at Client.<anonymous> (_debugger.js:159:14)
    at emitOne (events.js:90:13)
    at Client.emit (events.js:182:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Client.Readable.push (_stream_readable.js:111:10)
    at TCP.onread (net.js:531:20)

FYI I didn't enter the cont on the debug> cont line, that's echoing the cont above. I only entered the conts which appear alone

I can reproduce this on arbitrary source; I just tried with some for-browser code

I made this issue while causing this with urxvt, I'm now reproducing it in st

My versions match thefourtheye besides node being 5.10.0 & v8 being 4.6.85.31

@serprex serprex changed the title node debug fails if 'cont' entered while connectint node debug fails if 'cont' entered while connecting Apr 2, 2016
@Trott
Copy link
Member

Trott commented Jul 7, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. The debugger has been deprecated and aliased to the inspector in recent versions of Node.js. I am unable to replicate this on those versions. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants