Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsed URL objects have a colon in protocol field. #3176

Closed
wsmd opened this issue Oct 5, 2015 · 2 comments
Closed

Parsed URL objects have a colon in protocol field. #3176

wsmd opened this issue Oct 5, 2015 · 2 comments
Labels
question Issues that look for answers. url Issues and PRs related to the legacy built-in url module.

Comments

@wsmd
Copy link

wsmd commented Oct 5, 2015

When I try to parse a url using url.parse(), the protocol has a colon at the end.

Example

The following command

url.parse("https://avatars3.githubusercontent.com/u/2100222")

returns

Url {
  protocol: 'https:',
  ...
}

Shouldn't the protocol be http instead of http:? If not, what's the point of having it included?

@thefourtheye thefourtheye added question Issues that look for answers. url Issues and PRs related to the legacy built-in url module. labels Oct 5, 2015
@mscdex
Copy link
Contributor

mscdex commented Oct 5, 2015

See #1237.

@ChALkeR
Copy link
Member

ChALkeR commented Oct 5, 2015

Nothing to do here: no problem, question already answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that look for answers. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

No branches or pull requests

4 participants