Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal deprecation warning in REPL #37445

Open
targos opened this issue Feb 19, 2021 · 3 comments
Open

internal deprecation warning in REPL #37445

targos opened this issue Feb 19, 2021 · 3 comments
Labels
domain Issues and PRs related to the domain subsystem. inspector Issues and PRs related to the V8 inspector protocol repl Issues and PRs related to the REPL subsystem.

Comments

@targos
Copy link
Member

targos commented Feb 19, 2021

$ node
Welcome to Node.js v15.8.0.
Type ".help" for more information.
> process.kill(process.pid, 'SIGUSR1')
Debugger listening on ws://127.0.0.1:9229/5dea70fb-20d8-45a0-942b-a45d186fc3f5
For help, see: https://nodejs.org/en/docs/inspector
true
> (node:25150) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. (Triggered by calling  on process.)
    at emitMakeCallbackDeprecation (node:domain:129:13)
    at process.topLevelDomainCallback (node:domain:143:5)
    at process.callbackTrampoline (node:internal/async_hooks:130:14)
    at REPLServer.Interface._setRawMode (node:readline:344:43)
    at REPLServer.defaultEval (node:repl:521:18)
    at bound (node:domain:416:15)
    at REPLServer.runBound [as eval] (node:domain:427:12)
    at REPLServer.onLine (node:repl:836:10)
    at REPLServer.emit (node:events:390:22)
    at REPLServer.EventEmitter.emit (node:domain:470:12)
@benjamingr benjamingr added the repl Issues and PRs related to the REPL subsystem. label Feb 19, 2021
@EladKeyshawn
Copy link

@targos Hey, can I ask what can be done in this situation? Should the warning not be printed at all ?

@targos
Copy link
Member Author

targos commented Apr 19, 2021

I'm not familiar with this part of the code, but I think the first thing we should try to do is avoid using the deprecated API.

@EladKeyshawn
Copy link

I'm not familiar with this part of the code, but I think the first thing we should try to do is avoid using the deprecated API.

Alright I'll take a look into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. inspector Issues and PRs related to the V8 inspector protocol repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants