New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spam #38639
Comments
getFormat
and getSource
hooks to accomplish chaining, too, not just to solve #34144, so this PR would be a prerequisite for a chaining PR. I’ll try to find time soon to finish this up and get all the tests passing.
Hello @malmirhadis2, is there a specific reason for breaking this out into a separate issue? Was the intention to add this to our meeting agenda? We should probably do that so we can talk about it on Friday since this is one of our key talking points. /cc @nodejs/loaders |
This is a repost of something I posted a long time ago; possibly spam? |
@malmirhadis2 An issue to discuss this exists, and that is one of the proposals: #36954 And a PR needed before that can be implemented is #37468, which is landing soon. |
@GeoffreyBooth at the very least a duplicate. The OP has some repos but they're just fresh forks of major libraries (ex several Node.js ones). |
I’ve been looking into trying to implement loader chaining, where each user loader can modify the return value of the previous one(s), for all hooks. I think we need to merge the
getFormat
andgetSource
hooks to accomplish chaining, too, not just to solve #34144, so this PR would be a prerequisite for a chaining PR. I’ll try to find time soon to finish this up and get all the tests passing.Originally posted by @GeoffreyBooth in #35524 (comment)
The text was updated successfully, but these errors were encountered: