Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spam #38639

Closed
malmirhadis2 opened this issue May 11, 2021 · 4 comments
Closed

spam #38639

malmirhadis2 opened this issue May 11, 2021 · 4 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@malmirhadis2
Copy link

I’ve been looking into trying to implement loader chaining, where each user loader can modify the return value of the previous one(s), for all hooks. I think we need to merge the getFormat and getSource hooks to accomplish chaining, too, not just to solve #34144, so this PR would be a prerequisite for a chaining PR. I’ll try to find time soon to finish this up and get all the tests passing.

Originally posted by @GeoffreyBooth in #35524 (comment)

@mscdex mscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label May 11, 2021
@mscdex mscdex changed the title I’ve been looking into trying to implement loader chaining, where each user loader can modify the return value of the previous one(s), for all hooks. I think we need to merge the getFormat and getSource hooks to accomplish chaining, too, not just to solve #34144, so this PR would be a prerequisite for a chaining PR. I’ll try to find time soon to finish this up and get all the tests passing. esm: Implementing loader chaining May 11, 2021
@DerekNonGeneric DerekNonGeneric added the loaders Issues and PRs related to ES module loaders label May 11, 2021
@DerekNonGeneric
Copy link
Contributor

DerekNonGeneric commented May 11, 2021

Hello @malmirhadis2, is there a specific reason for breaking this out into a separate issue?

Was the intention to add this to our meeting agenda?

We should probably do that so we can talk about it on Friday since this is one of our key talking points.

/cc @nodejs/loaders

@GeoffreyBooth
Copy link
Member

This is a repost of something I posted a long time ago; possibly spam?

@JakobJingleheimer
Copy link
Contributor

@malmirhadis2 An issue to discuss this exists, and that is one of the proposals: #36954

And a PR needed before that can be implemented is #37468, which is landing soon.

@JakobJingleheimer
Copy link
Contributor

@GeoffreyBooth at the very least a duplicate. The OP has some repos but they're just fresh forks of major libraries (ex several Node.js ones).

@DerekNonGeneric DerekNonGeneric added the duplicate Issues and PRs that are duplicates of other issues or PRs. label May 12, 2021
@mscdex mscdex closed this as completed May 12, 2021
@GeoffreyBooth GeoffreyBooth removed esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels May 12, 2021
@GeoffreyBooth GeoffreyBooth changed the title esm: Implementing loader chaining spam May 12, 2021
@nodejs nodejs locked and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

5 participants