Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-generator-mips.cc: call of overloaded ‘Operand(int64_t)’ is ambiguous #40624

Closed
kapouer opened this issue Oct 27, 2021 · 4 comments
Closed
Labels
build Issues and PRs related to build files or the CI. mips Issues and PRs related to the MIPS architecture.

Comments

@kapouer
Copy link
Contributor

kapouer commented Oct 27, 2021

Version

16.11.1

Platform

debian linux bookworm

Subsystem

build

What steps will reproduce the bug?

Build for "mipsel" target.
The build was done on a real mips host, so not a cross-build issue.

How often does it reproduce? Is there a required condition?

Always it's a build failure.

What is the expected behavior?

A successful build like the one for mips64el
https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=mips64el&ver=16.11.1%7Edfsg-1&stamp=1635301000&raw=0

What do you see instead?

https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=mipsel&ver=16.11.1~dfsg-1&stamp=1635308357&file=log

Additional information

Built with gcc 11.

@targos targos added build Issues and PRs related to build files or the CI. mips Issues and PRs related to the MIPS architecture. labels Oct 27, 2021
@targos
Copy link
Member

targos commented Oct 27, 2021

We do not officially support the mips architectures, so you will probably have to find a fix yourself .

code-generator-mips.cc is part of V8, so I would first check whether this is fixed upstream:

  • If it is, the patch needs to be identified and backported to Node.js 16.
  • If it is not, the fix must be done in V8 first, then it can be backported.

@kapouer
Copy link
Contributor Author

kapouer commented Oct 28, 2021

No problem, i know that mips* are not supported. But i report anyway so it might avoid others to get lost.
Also this one was easy to fix...

--- a/deps/v8/src/compiler/backend/mips/code-generator-mips.cc
+++ b/deps/v8/src/compiler/backend/mips/code-generator-mips.cc
@@ -4230,7 +4230,7 @@
     } else if (FLAG_debug_code) {
       __ Assert(eq, AbortReason::kUnexpectedAdditionalPopValue,
                 g.ToRegister(additional_pop_count),
-                Operand(static_cast<int64_t>(0)));
+                Operand(static_cast<int>(0)));
     }
   }
   // Functions with JS linkage have at least one parameter (the receiver).

Should i PR this ?

@kapouer
Copy link
Contributor Author

kapouer commented Oct 28, 2021

Forwarded to upstream v8: https://bugs.chromium.org/p/v8/issues/detail?id=12345

@bnoordhuis
Copy link
Member

It seems unlikely that this is ever going to get fixed now that V8 is dropping support for mips32 so I'll take the liberty of closing out this issue.

Note how the mips32 port hasn't received any love since October 2021. It's already effectively unmaintained.

@bnoordhuis bnoordhuis closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. mips Issues and PRs related to the MIPS architecture.
Projects
None yet
Development

No branches or pull requests

3 participants