Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.14.1 release altered fetch timeout defaults from 300s to 30s #46706

Closed
mccaig opened this issue Feb 18, 2023 · 1 comment · Fixed by #46711
Closed

18.14.1 release altered fetch timeout defaults from 300s to 30s #46706

mccaig opened this issue Feb 18, 2023 · 1 comment · Fixed by #46711
Labels
fetch Issues and PRs related to the Fetch API

Comments

@mccaig
Copy link

mccaig commented Feb 18, 2023

Version

v18.14.1

Platform

Linux

Subsystem

undici

What steps will reproduce the bug?

  1. Make a request using the fetch API that takes longer than 30 seconds. Using the defaults it will fail, in my case, with cause: HeadersTimeoutError: Headers Timeout Error

How often does it reproduce? Is there a required condition?

Any request that exceeds 30 seconds for headers or body content.

What is the expected behavior?

Default timeout should remain at 300s as in the previous 18.14.0 release

What do you see instead?

Timeout occurs at 30 seconds.

Additional information

The 18.14.1 release updated the undici client, which had recently altered the header and body timeout defaults to 30 seconds, down from 300 seconds as a result of this commit: nodejs/undici#1870

The defaults have since been changed back to 300s in the client: nodejs/undici#1937

So it looks like a fix is simply a matter of bumping to the new undici release.

@mcollina
Copy link
Member

It's incoming, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetch Issues and PRs related to the Fetch API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants