Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap2junit failing to parse non-ASCII characters #47048

Closed
MoLow opened this issue Mar 12, 2023 · 3 comments · Fixed by nodejs/build#3272
Closed

tap2junit failing to parse non-ASCII characters #47048

MoLow opened this issue Mar 12, 2023 · 3 comments · Fixed by nodejs/build#3272
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@MoLow
Copy link
Member

MoLow commented Mar 12, 2023

recently on some platforms the build job has passed all tests but failed on parsing the tap due to existence of non-ASCII characters
https://ci.nodejs.org/job/node-test-commit-linux-containered/36476/nodes=ubuntu1804_sharedlibs_openssl111_x64/console
@MoLow
Copy link
Member Author

MoLow commented Mar 12, 2023 •
edited
Loading

I am willing to tackle tap2junit but it seems like all the recent changes/fixes to it were not released yet: nodejs/tap2junit#41
so I want to know that if I fix it, there is someone who can release the fix

@MoLow MoLow added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Mar 12, 2023
@MoLow MoLow changed the title Issue with tap2junit tap2junit failing to parse non-ASCII characters Mar 12, 2023
@MoLow
Copy link
Member Author

MoLow commented Mar 12, 2023

alternatively, we can utilize the test runner TAP parser to replace tap2junit with a simple js script:
https://github.com/MoLow/node/blob/b2a09f955d16d1dbcb5018791a64163b7334250d/tools/tap2junit/index.js

@MoLow
Copy link
Member Author

MoLow commented Mar 13, 2023

CC @nodejs/build @nodejs/python

@cclauss cclauss mentioned this issue Mar 13, 2023
Closed
@MoLow MoLow mentioned this issue Mar 13, 2023
Merged
@MoLow MoLow mentioned this issue Mar 20, 2023
Closed
This was referenced Mar 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ansible: use explicit tap2junit version MoLow/build
1 participant
@MoLow