Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add latest brotli 1.1.0 bindings with compression dictionary support #52250

Open
nhelfman opened this issue Mar 28, 2024 · 2 comments
Open
Assignees
Labels
brotli Issues and PRs related to the brotli dependency. feature request Issues that request new features to be added to Node.js.

Comments

@nhelfman
Copy link

What is the problem this feature will solve?

Current node brotli compression does not support compression dictionary.
The dictionary option only supported for deflate/inflate according to documentation:

dictionary | | | (deflate/inflate only, empty dictionary by default)

This prevents using node.js directly to create compression dictionary diffs at build time which is necessary in order to adopt Compression dictionary transport

What is the feature you are proposing to solve the problem?

Add latest code/binaries and binding to compression options to support latest brotli (https://github.com/google/brotli) version 1.1.0 so that we can use the dictionary option in brotli.

cc: @benjamingr

What alternatives have you considered?

No response

@nhelfman nhelfman added the feature request Issues that request new features to be added to Node.js. label Mar 28, 2024
@VoltrexKeyva VoltrexKeyva added the brotli Issues and PRs related to the brotli dependency. label Mar 30, 2024
@benjamingr
Copy link
Member

@nodejs/zlib it looks like this just needs exposing in the API JS side

@juanarbol
Copy link
Member

I can work on this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brotli Issues and PRs related to the brotli dependency. feature request Issues that request new features to be added to Node.js.
Projects
Status: Pending Triage
Development

No branches or pull requests

4 participants