-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint broken when node built without openssl #5610
Comments
Why do we use |
That would assume that the machine has a global node installed, which may not be the case. |
I don't think we can make an assumption about a global node. They seem to use md5 from crypto: /**
* create a md5Hash of a given string
* @param {string} str the string to calculate the hash for
* @returns {string} the calculated hash
*/
function md5Hash(str) {
return crypto
.createHash("md5")
.update(str, "utf8")
.digest("hex");
} Perhaps just file a PR upstream with a javascript version of md5? |
@jasnell it should be a requirement, then. |
@vkurchatkin I disagree, everything else works without a global node and iirc that is how the CI runs. We should attempt to make it run without that. |
@Fishrock123 the idea is that node compiled without OpenSSL is kind of broken: a lot of modules won't work. We can make eslint work by sticking js implementation of md5, but it is not a good long term solution:
|
@vkurchatkin if its broken we shouldn't support it. The test suite currently passes (albeit with skipped crypto tests) and I don't think we should remove that build option. |
@jbergstroem it's broken in a sense that it's not "node" platform, it's "node-without-ssl" platform, and |
@vkurchatkin ok; |
@jbergstroem by supporting "node-without-ssl" I mean running tests on it as a part of CI. It's very unlikely that they would do this (nobody does) |
The other option here is to simply disable |
FWIW, in CI we run nodejs from FreeBSD's |
Fixed with #6132. |
When building Node.js with
configure --without-ssl
,make lint
andmake test
error out with:The text was updated successfully, but these errors were encountered: