-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls.createServer secureOptions #9025
Comments
I'm assuming you meant |
I'm sorry for being unclear earlier, I've tried to document below what I've traced through the code. The constructor for the tls Server calls self.setOptions, which has the following line: https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L901 that ends up getting passed again by: https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L761 which is passed to the SecureContext constructor as flags: which is then passed again by: ending with it calling the SecureContext::SetOptions method that passes through the options to OpenSSL here: https://github.com/nodejs/node/blob/master/src/node_crypto.cc#L875 |
@mscdex I know you're very busy, any chance you've had a chance to to look at my clarifications? |
Why not use |
For my specific use-case, we can get a greater degree of flexibility by allowing users to blacklist TLSv1 while continuing to support TLSv1.1 and TLSv1.2. |
/cc @nodejs/crypto |
|
Fantastic, thanks @bnoordhuis. I'll get a pull request together for this. |
closed by #9800, see #9340 (comment) |
I was looking for a way to limit the versions of TLS that are supported, and I came across the
secureOptions
in thetls.createServer
method that appears to do exactly that.However, I noticed that the documentation doesn't reference this option. Is this something that a pull request to modify the docs would be appropriate, or is this something that you all intend to deprecate/remove in the near-future?
The text was updated successfully, but these errors were encountered: