Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test reading binary resources that are injected at build time #11

Open
jviotti opened this issue Sep 9, 2022 · 3 comments
Open
Assignees

Comments

@jviotti
Copy link
Member

jviotti commented Sep 9, 2022

No description provided.

@jviotti jviotti changed the title Test reading binary resources that are injected at build time Add a test reading binary resources that are injected at build time Sep 9, 2022
@RaisinTen
Copy link
Contributor

Isn't Postject concerned only about resources that are injected post-compilation?

@jviotti
Copy link
Member Author

jviotti commented Sep 12, 2022

In theory, whether a resource is injected pre or post compilation doesn't even matter, as they both result in sections/segments appended to the binary. I believe this was raised by @dsanders11 as a way to test that the reading operation is done correctly and does not depend on quirks about how we actually inject with Postject as well.

@dsanders11
Copy link
Contributor

Isn't Postject concerned only about resources that are injected post-compilation?

I would say no. The run-time API is agnostic to how the resource was added, pre or post, and I think there are valid use cases for pre, it makes things simpler and is guaranteed bug free, since it's using standard techniques.

@dsanders11 dsanders11 self-assigned this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants