Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body.dump() is missing abort signal support #1978

Closed
ronag opened this issue Mar 1, 2023 · 1 comment · Fixed by #1993
Closed

body.dump() is missing abort signal support #1978

ronag opened this issue Mar 1, 2023 · 1 comment · Fixed by #1993
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ronag
Copy link
Member

ronag commented Mar 1, 2023

We should support body.dump({ signal })
@ronag ronag added enhancement New feature or request good first issue Good for newcomers labels Mar 1, 2023
@debadree25
Copy link
Member

Should it throw an error when aborted with signal?

@debadree25 debadree25 mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add abort signal to body.dump() debadree25/undici
2 participants
@ronag @debadree25