Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose WebSocket to fetch bundle #2216

Closed
KhafraDev opened this issue Aug 17, 2023 · 3 comments · Fixed by #2217
Closed

expose WebSocket to fetch bundle #2216

KhafraDev opened this issue Aug 17, 2023 · 3 comments · Fixed by #2217

Comments

@KhafraDev
Copy link
Member

is it time to expose our WebSocket in node?
@ronag
Copy link
Member

ronag commented Aug 17, 2023

SGTM

@KhafraDev KhafraDev mentioned this issue Aug 17, 2023
Merged
@metcoder95
Copy link
Member

Is there any possible gotcha to be aware of?

@KhafraDev
Copy link
Member Author

adding globals is a semver major change and potentially breaking change. I assume that there will also be some dissent to adding WebSocket, like there has been to adding basically any web spec in node.

it probably also needs discussions and the like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expose websocket in node bundle KhafraDev/undici
3 participants
@ronag @metcoder95 @KhafraDev