Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Flaky test for Fetch + HTTP/2 #2321

Closed
metcoder95 opened this issue Oct 9, 2023 · 2 comments · Fixed by #2337
Closed

test: Flaky test for Fetch + HTTP/2 #2321

metcoder95 opened this issue Oct 9, 2023 · 2 comments · Fixed by #2337
Labels
bug Something isn't working Tests Changes related to the unit tests

Comments

@metcoder95
Copy link
Member

metcoder95 commented Oct 9, 2023

Bug Description

The following test is unstable and fails from time to time; it requires further research on how to handle it better. An initial guest is a possible race condition but it requires further investigation.

'[Fetch] Should handle h2 request with body (stream)',

Reproducible By

  • Any PR, often on v20 tests

Expected Behavior

Logs & Screenshots

    # Subtest: [Fetch] Should handle h2 request with body (stream)
        1..8
        ok 1 - should be equal
        ok 2 - should be equal
        ok 3 - should be equal
        ok 4 - should be equal
        ok 5 - should be equal
        ok 6 - should be equal
        ok 7 - should be equal
        not ok 8 - should be equal

Environment

  • Often v20.

Additional context

@metcoder95 metcoder95 added bug Something isn't working Tests Changes related to the unit tests labels Oct 9, 2023
@KhafraDev
Copy link
Member

maybe moving the stream.end() to after the for await?

@metcoder95
Copy link
Member Author

Yeah, most likely that might be the scenario as there's race condition between consuming the request's body, and start doing the assertions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tests Changes related to the unit tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants