Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici does not work with Nodejs 12 and below #2469

Closed
bugb opened this issue Nov 27, 2023 · 1 comment
Closed

Undici does not work with Nodejs 12 and below #2469

bugb opened this issue Nov 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bugb
Copy link
Contributor

bugb commented Nov 27, 2023

Bug Description

Since the PR, the library will not work with Nodej12 and below due to optional chainning:

https://github.com/nodejs/undici/pull/2402/files#diff-d3320266ee631518dc58b9cb1a3a3bc81526746db0603fb8bc32a535cc90d7a4R183

image

Reproducible By

  • Step 1: Make sure that you are using Nodejs 12 or below.
  • Step 2: Using undici in any Nodejs project.

Expected Behavior

This should be compatible with Nodejs 12 or below

Logs & Screenshots

When using undici latest version we can get the following error:
image

Environment

Nodejs 12.22.12 and below

Additional context

I have created a PR here: #2470
Please help me to review it!

Thanks!

@ronag
Copy link
Member

ronag commented Nov 27, 2023

We don't support EOL versions of node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants