use fetch utility to parse range header instead of custom one?

[KhafraDev]

This:

undici/lib/core/util.js

Lines 461 to 471 in af9aaea

	function parseRangeHeader (range) {
	if (range == null || range === '') return { start: 0, end: null, size: null }
	const m = range ? range.match(/^bytes (\d+)-(\d+)\/(\d+)?$/) : null
	return m
	? {
	start: parseInt(m[1]),
	end: m[2] ? parseInt(m[2]) : null,
	size: m[3] ? parseInt(m[3]) : null
	}
	: null

can now be replaced with:

undici/lib/fetch/util.js

Line 1030 in af9aaea

function simpleRangeHeaderValue (value, allowWhitespace) {

I think sharing more code between fetch and the rest of undici would be nice, especially now that fetch is supported in every version of node that undici does.

[metcoder95]

It is only used within RetryHandler so it should be safe to replace it; the only thing that seems missing is that it does not consider the total byte size of the response if provided. We can infer it as the sizeEnd and fallback to content-length if missed

[rossilor95]

Hi @KhafraDev @metcoder95, I was taking a look at this issue and I think these 2 functions are meant to parse different type of headers:

• simpleRangeHeaderValue parses the Range request header (format bytes=<range-start>-<range-end>)
• parseRangeHeader parses the Content-Range response header (format bytes <range-start>-<range-end>/<size>)

Is this correct? Thank you

[Uzlopak]

thats why i renamed parseRangeHeader to parseContentRangeHeader in #2779

[rossilor95]

Cool! So, can this be closed?

[KhafraDev]

yeah, naming confused me. They serve different purposes