Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize consumeEnd json/text #2505

Closed
ronag opened this issue Dec 6, 2023 · 1 comment · Fixed by #2510
Closed

Optimize consumeEnd json/text #2505

ronag opened this issue Dec 6, 2023 · 1 comment · Fixed by #2510
Labels
enhancement New feature or request

Comments

@ronag
Copy link
Member

ronag commented Dec 6, 2023 •
edited

In function consumeEnd (consume)

We do:

Buffer.concat(body).toString()

I think there can be faster or at least more memory efficient alternatives, e.g. using a streaming TextDecoder
@ronag ronag added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 6, 2023
@ronag
Copy link
Member Author

ronag commented Dec 6, 2023

@tsctx

@tsctx tsctx mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: optimize consumeEnd tsctx/undici
1 participant
@ronag