Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCov has wrong base?! #2764

Closed
Uzlopak opened this issue Feb 15, 2024 · 3 comments
Closed

CodeCov has wrong base?! #2764

Uzlopak opened this issue Feb 15, 2024 · 3 comments

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 15, 2024

CodeCov has an old state and shows that the base branch has some 2 month old commit. Somebody with permissions on codecov should fix that?

@metcoder95
Copy link
Member

cc @mcollina @ronag

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 19, 2024

maybe the issue is, that codecov action does not support tokenless upload.

see
https://github.com/codecov/codecov-action/releases/tag/v4.0.0

They have instructions on how to provide the codecov token via secret
https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

But i think this maybe wont work when using pkgjs/action/.github/workflows/node-test.yaml

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 19, 2024

That reusable workflow is swallowing the warning from the codecov action:

https://github.com/nodejs/undici/actions/runs/7961422831/job/21732611626

Screenshot from 2024-02-19 22-48-30

@Uzlopak Uzlopak closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants