response content-length mismatch waits for timeout

[ronag]

I'm not sure but I think it should be possible to detect a response content-length mismatch without waiting for timeout. Unclear why the parser does not detect this.

test('response invalid content length', (t) => {
  t.plan(3)

  const server = createServer((req, res) => {
    res.writeHead(200, {
      'content-length': 10
    })
    res.end('123')
  })
  t.teardown(server.close.bind(server))
  server.listen(0, () => {
    const client = new Client(`http://localhost:${server.address().port}`)
    t.teardown(client.destroy.bind(client))

    client.on('disconnect', (err) => {
      t.strictEqual(err.code, 'UND_ERR_SOCKET')
    })

    client.request({
      path: '/',
      method: 'GET'
    }, (err, data) => {
      t.error(err)
      data.body
        .on('end', () => {
          t.fail()
        })
        .on('error', (err) => {
          t.strictEqual(err.code, 'UND_ERR_SOCKET')
        })
        .resume()
    })
  })
})

[ronag]

Would be even better if we could throw a descriptive error, e.g. "response body content-length mismatch"

[simone-sanfratello]

I'll work on that

[ronag]

nodejs/node#39133