Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Interceptable type in export ? #1306

Closed
fraxken opened this issue Mar 28, 2022 · 3 comments
Closed

Missing Interceptable type in export ? #1306

fraxken opened this issue Mar 28, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@fraxken
Copy link
Member

fraxken commented Mar 28, 2022

Bug Description

While working on UT (with TypeScript) for one of our project we were unable to found the Interceptable type in the undici export.

https://github.com/nodejs/undici/blob/main/types/mock-interceptor.d.ts#L88

Reproducible By

//

Expected Behavior

Export the Interceptable type.

Environment

Node.js 16.13.x on Windows 10.
@fraxken fraxken added the bug Something isn't working label Mar 28, 2022
@fraxken
Copy link
Member Author

fraxken commented Mar 28, 2022

I'm ok to send a PR if maintainer confirm this should be exported :)

@mcollina
Copy link
Member

I think it's ok to export it!

@fraxken fraxken mentioned this issue Mar 29, 2022
Merged
@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 14, 2024

@nodejs/undici

I guess we can close this as solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @fraxken @Uzlopak @KhafraDev