-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #11
Comments
Six macros is not support on windows. See #27 (comment). |
@gengjiawen Possible fix in #30. Obviously won't work for sockets etc. |
Yeap. Other macros works in |
Current state of known Windows issues:
|
Non-console executables don't have stdin/out/err which causes |
Just a simple question, why not add an #ifdef for win32 and add simple validation at the libuv wrapper, which would try at first to create the original string, and if failed, then bubble up an exception (assuming that maybe someday ":" would be supported by windows system? I hope this sounds somewhat reasonable - since I haven't dived into the libuv wrapper. but this seems like a solution that would span a solution on multiple environments as long as they're windows ( if when comes a day where windows FS allows ":") |
There are a number of TODO comments sprinkled throughout the code. A number of them are Windows specific. The most important are probably in
uvwasi__is_absolute_path()
anduvwasi__resolve_path()
. Once those ones are resolved there will still be some Windows limitations, but libuv should smooth out most of them.The text was updated successfully, but these errors were encountered: