-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing stripHtml #67
Comments
Hi, I've had complaints about removing the feature (or actually it was not removed but not implemented, since v0.3 is a complete rewrite, not just an update), so I'll bring it back as an optional feature, like generateTextFromHTML: true or smth, not sure about the property name yet. If the HTML is converted to text by default, it would not be possible to generate simple structured (content-type: text/html) e-mails with HTML but only multipart (content-type: multipart/alternative) messages. This is a problem for dumber parsers that rely on simple input. Or I might make skipping the text generation optional, to keep compliance with the older API. Not sure yet, have to think about it. Anyhow, the feature is coming back. |
Thanks, wise decision :) I'd make it optional as it's a rather "magic" feature people should switch on explicitly. Do you see a time frame for this one? |
I think I'll have it published by tomorrow. |
Awesome. |
Fixed with cd566c5 |
Thanks. |
Previous versions generated a plain text alternative when only given a HTML body. In 0.3 this disappeared, the whole regex magic used there has gone.
It would be great to have that feature back.
The text was updated successfully, but these errors were encountered: