Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing stripHtml #67

Closed
hannesgassert opened this issue Feb 14, 2012 · 6 comments
Closed

Missing stripHtml #67

hannesgassert opened this issue Feb 14, 2012 · 6 comments

Comments

@hannesgassert
Copy link
Contributor

Previous versions generated a plain text alternative when only given a HTML body. In 0.3 this disappeared, the whole regex magic used there has gone.

It would be great to have that feature back.

@andris9
Copy link
Member

andris9 commented Feb 15, 2012

Hi,

I've had complaints about removing the feature (or actually it was not removed but not implemented, since v0.3 is a complete rewrite, not just an update), so I'll bring it back as an optional feature, like generateTextFromHTML: true or smth, not sure about the property name yet.

If the HTML is converted to text by default, it would not be possible to generate simple structured (content-type: text/html) e-mails with HTML but only multipart (content-type: multipart/alternative) messages. This is a problem for dumber parsers that rely on simple input.

Or I might make skipping the text generation optional, to keep compliance with the older API.

Not sure yet, have to think about it. Anyhow, the feature is coming back.

@hannesgassert
Copy link
Contributor Author

Thanks, wise decision :)

I'd make it optional as it's a rather "magic" feature people should switch on explicitly.

Do you see a time frame for this one?

@andris9
Copy link
Member

andris9 commented Feb 15, 2012

I think I'll have it published by tomorrow.

@hannesgassert
Copy link
Contributor Author

Awesome.

@andris9
Copy link
Member

andris9 commented Feb 15, 2012

Fixed with cd566c5

@andris9 andris9 closed this as completed Feb 15, 2012
@hannesgassert
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants