pmSleep and Timer suspend enabled by defaul despite runtime impact on all code.

[TerryE]

BUG REPORT

Expected behaviour

PR #1231. as this case updated sdk-overrides/include/osapi.h

#define os_timer_arm(timer_ptr, duration, mode) do{swtmr_register(timer_ptr); \
  ets_timer_arm_new(timer_ptr, duration, mode, 1);}while(0);

and similarly for disarm, and these swtmr both add a hidden runtime memory and call overhead overhead and the ability to fail silently due to out-of-memory conditions.

• No change to the core RTS which changes the timing and runtime nature of another module should be introduced without explicitly highlighting this runtime impact as part of the change. The documentation should also explicitly point this out.

• In such cases, the user_config.h should also disable the feature by default, with a referenced to the issue in the documentation.

Actual behaviour

The two key parameters which confiigure this functionality lines 118:119 are enabled by default. They shouldn't be. And the additional explanation needs to be added to the documentation.

NodeMCU version

Current dev and master

Test code & Hardware

N/A