Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Modularize/fully de-tangle BottomNavigationBar #16

Open
1 task
toshify opened this issue May 13, 2020 · 0 comments
Open
1 task

refactor: Modularize/fully de-tangle BottomNavigationBar #16

toshify opened this issue May 13, 2020 · 0 comments
Labels
front end good first issue Good for newcomers polish Improvements to make features smoother.

Comments

@toshify
Copy link
Collaborator

toshify commented May 13, 2020 •
edited

Dev copies the BottomNavigationBar to another project and reuses it with minimal efforts. This ensures loose coupling of modules like the BottomNavigationBar. Currently the BottomNaviagtionBar is dependent on the Ionic framework. Instead, the button icons that depend on Ionic should be passed into the BottomNavigationBar, so that it becomes detangled.

Requires

  • Changing BottomNavigationBar to take the icons it uses as input rather than globally request them.
@toshify toshify added front end polish Improvements to make features smoother. labels May 13, 2020
@toshify toshify changed the title Dev reuses BottomNavigationBar modularly refactor: Dev reuses BottomNavigationBar modularly May 21, 2021
@toshify toshify added the good first issue Good for newcomers label May 21, 2021
@toshify toshify changed the title refactor: Dev reuses BottomNavigationBar modularly refactor: Modularize/fylly de-tangle BottomNavigationBar Sep 7, 2021
@toshify toshify changed the title refactor: Modularize/fylly de-tangle BottomNavigationBar refactor: Modularize/fully de-tangle BottomNavigationBar Sep 7, 2021
@toshify toshify removed this from Inbox in Development and operations Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
front end good first issue Good for newcomers polish Improvements to make features smoother.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toshify