Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep(parse-url): replace with native URL #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dep(parse-url): replace with native URL #39

wants to merge 1 commit into from

Conversation

msimerson
Copy link

@msimerson msimerson commented Dec 11, 2023 •
edited
Loading

  • Fixes Critical CVE with parse-url dependency #37
  • replace Travis CI with GitHub Actions
    • add codeql
    • add windows testing (can be ignored or easily disabled)
  • CI with GitHub Actions has been tested and you can see the output over here in my fork and in the screenshot below. I updated the readme file so that if you merge this PR, the CI test badge points to the GHA tests in your repo.
  • the CI tests against v8 and automatically against every LTS version of node.js. Currently that's node 18 & 20. If dropping node 8 support is acceptable, then the polyfill can be removed.
  • After merging this PR, coveralls will show results in your fork.
  • This PR is minimal, changing only what is required to remove parse-url and get GHA testing functional

CI result

Screenshot 2023-12-11 at 2 28 31 PM

@msimerson msimerson force-pushed the remove-parse-url branch 5 times, most recently from dc98d41 to 4a17c86 Compare December 11, 2023 22:19
@msimerson
dep(parse-url): replace with native URL
b91cb4e 
- polyfill URL for node.js 8
- ci: replace Travis with GitHub Actions
    - add codeql testing
    - doc(readme): update CI badge url
- bump version to 2.1.1
- doc(changelog): update for 2.1.1
- doc(readme): bump copyright year to 2023
- dep(eslint) bump version
@msimerson msimerson mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Critical CVE with parse-url dependency
1 participant
@msimerson