New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[events map] Can we make the z-index for future events > z-index for past events? #125
Comments
Given new events are prepended to sheet and old events are on bottom, simple reverse() on data after response should do the trick. Let me experiment with this on my localhost. |
Actually, disregard my previous comment - there's some date sorting taking place. |
Hm I also wasn't able to fix this. Seems like the styling of the marker can only be done though the attrebites of the simplestyle-spec, which doesn't support zIndex. I am not sure what the best solution is. I think this would require a PR to sheetsee-maps, somehow supporting non-GeoJSON styling. But maybe there is another way? |
I just made the PR ☝️ which I think is the best fix. It sorts the dates before they go into the map (previously they were just being sorted before being listed, not before being mapped) and so now an upcoming NYC event will be above an older NYC event. I don't think a z-index would work actually because you wouldn't want a NYC marker floating ontop of a Georgia marker. |
Is it a bad idea to suggest showing only active markers & have toggable option to see all? |
@sudodoki I don't think it's a bad idea, I think there was just a want for a 💥 impact of showing all of them, but we could just have the front page show upcoming ones on the map and then the /events page can show all. |
We have an event in NYC coming up but the yellow flag is buried under grey flags. Is there any way to get a consistently greater z-index on future events?
The text was updated successfully, but these errors were encountered: