Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you still working on this? #33

Closed
mannyhenri opened this issue Jun 10, 2018 · 26 comments
Closed

Are you still working on this? #33

mannyhenri opened this issue Jun 10, 2018 · 26 comments

Comments

@mannyhenri
Copy link

mannyhenri commented Jun 10, 2018

Very interested in this plugin but is it possible you're not maintaining it anymore since the acquisition? ESLINT in my opinion is probably the best approach to write implement best practices around writing secured code.

If you're not maintaining it anymore would you be open to transfer this project to me? I'd like to keep it alive and update it with other rules.

@jesusprubio
Copy link
Contributor

Same here, are you still working on it? I would like to keep contributing. A "npm audit-code" or something similar would be awesome :)

@mannyhenri
Copy link
Author

@jesusprubio if we don't get an answer back let's fork this and keep it alive somewhere else...

@jesusprubio
Copy link
Contributor

Sure, but lets give them some days, it's Sunday today :). I have more rules and some ideas implemented locally, like support for rules to check the absence of stuff (instead the presence).

@mannyhenri
Copy link
Author

@jesusprubio of course can't wait to see what you came up with.

@mannyhenri
Copy link
Author

mannyhenri commented Jun 12, 2018

@jesusprubio just got word from the NPM team that our best option is to fork and work on it ourselves. So I'll fork it and invite you, works for you?

@mannyhenri
Copy link
Author

@evilpacket if we send you updates in ESLINT rules for this are you still looking into maintaining and updating it with new rules? I'm building a secured based template for @BedRock4 and want to leverage ESLINT rules to instill security best practices.

@trycrmr
Copy link

trycrmr commented Aug 22, 2018

Opened this topic on npm.community: https://npm.community/t/what-are-the-plans-for-eslint-plugin-security/1615

@amazzoccone
Copy link

Topic was closed 😞.

@evilpacket
Copy link
Contributor

evilpacket commented Oct 27, 2018 via email

@MVrachev
Copy link

MVrachev commented Feb 6, 2019

Is there an active fork of this project somewhere?
Because there is no response from @evilpacket again...
I have been searching for an active fork but there is none.

@webschik
Copy link

webschik commented Feb 6, 2019

@MVrachev, I support a version for TSLint - https://github.com/webschik/tslint-config-security, if you're interested.

@MVrachev
Copy link

MVrachev commented Feb 6, 2019

Wow, awesome! Thank you @webschik! I will have a look.

@kewilson
Copy link

So is this going to be maintained? If not has anyone found a suitable drop-in replacement? I'd also pony up time for being a maintainer to keep the repo alive and well going forward if there are no suitable replacements.

@MVrachev
Copy link

MVrachev commented Mar 27, 2019

I found one replacement - https://github.com/webschik/tslint-config-security.
That's a TSLint plugin. TSLint scans TypeScript files the same as ESLint does.

Because TypeScript is a superset of JavaScript TSLint can use its rules upon JavaScript files after configuration.

First, you need to install TSLint and configure it.
Here is an example configuration to scan JavaScript files with the plugin above:

tslint.json:

{
    "extends": ["tslint-config-security"],
    "jsRules": {
      "tsr-detect-buffer-noassert": [true],
      "tsr-detect-child-process": [true],
      "tsr-detect-eval-with-expression": [true],
      "tsr-detect-no-csrf-before-method-override": [true],
      "tsr-detect-non-literal-buffer": [true],
      "tsr-detect-non-literal-fs-filename": [true],
      "tsr-detect-non-literal-regexp": [true],
      "tsr-detect-non-literal-require": [true],
      "tsr-detect-possible-timing-attacks": [true],
      "tsr-detect-pseudo-random-bytes": [true],
      "tsr-detect-unsafe-regexp": [true],
      "tsr-disable-mustache-escape": [true],
      "tsr-detect-html-injection": [true],
      "tsr-detect-sql-literal-injection": [true],
      "tsr-detect-unsafe-cross-origin-communication": [true],
      "tsr-detect-unsafe-properties-access": [true]
  }
}

and if you want to use the --project option on the command line to scan your whole project you can add the following into your tsconfig.json:

{
  "compilerOptions": {
    "strict": true,
    "allowJs": true
  },
  "include": [
    "./**/*"
  ],
  "exclude":[
    "node_modules",
  ]
}

The "allowJs" flag is important here.

@evilpacket
Copy link
Contributor

I'd like to get some maintenance going on this again. I'm bad at open source and would welcome in some maintainers to assist. I'm on PTO this week and if I get a few hours here or there I plan to follow up on some of the PR's and issues.

If you would like to help maintain I'd like to chat.

@Berkmann18
Copy link

I'm down for helping in maintaining this package.

@codymikol
Copy link
Contributor

Let me know how I can help out :)

@pdehaan
Copy link
Contributor

pdehaan commented Apr 3, 2019

@evilpacket Is the contents of blog.liftsecurity.io still available somewhere (or do we have to use archive.org to try and scrape the cached content)?
It'd be nice to put the docs along with the rules instead of having to rely on archive.org links.

@evilpacket
Copy link
Contributor

@pdehaan yes all the markdown files are still available but it's a private repo. Let's coordinate this via #34

@UziTech
Copy link

UziTech commented May 28, 2020

@evilpacket are you still looking for maintainers for this repo?

@gkouziik
Copy link

@evilpacket are you still looking for maintainers for this repo?

@UziTech I am looking for maintainers for my repo eslint-plugin-security-node is the package name in npm.

@UziTech
Copy link

UziTech commented Nov 12, 2020

@gkouziik is that a fork of this package?

@gkouziik
Copy link

@UziTech No its not a fork, they just have some similar rules

@UziTech
Copy link

UziTech commented Nov 13, 2020

@gkouziik I would be willing to help maintain it.

@rfm-bot
Copy link

rfm-bot commented Dec 28, 2020

🚧 Is this repo looking for support?
Hello, we created this issue becuase the user @UziTech told us you are calling for maintainers.
✅ If you're looking for collaborators no action is required.
👮🏻‍♂️ If this repo is well-supported please put a comment here sospedra/rfm#69 and we'll close it immediately.
Sorry for any inconvinience. We understand this message can feel spammy but we really think is good to double-check first with the current owners :)

@nzakas
Copy link
Contributor

nzakas commented Mar 25, 2022

See #71.

@nzakas nzakas closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests