NO_PROXY variable for npm (#199)

* Update assemble * Update README.md
nodeshift-archived · Jul 4, 2019 · 20872c2 · 20872c2
1 parent aeb2862
commit 20872c2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -83,6 +83,7 @@ NPM_MIRROR  | Sets the npm registry URL
 NODE_ENV    | Node.js runtime mode (default: "production")
 HTTP_PROXY  | use an npm proxy during assembly
 HTTPS_PROXY | use an npm proxy during assembly
+NO_PROXY    | set URLs that should be excluded from proxying during assembly
 
 One way to define a set of environment variables is to include them as key value pairs
 in a `.s2i/environment` file in your source repository.

diff --git a/s2i/assemble b/s2i/assemble
@@ -31,6 +31,16 @@ if [ ! -z $https_proxy ]; then
 	npm config set https-proxy $https_proxy
 fi
 
+if [ ! -z $NO_PROXY ]; then
+	echo "---> Setting npm no proxy config to $NO_PROXY"
+	npm config set no-proxy $NO_PROXY
+fi
+
+if [ ! -z $no_proxy ]; then
+	echo "---> Setting npm no proxy config to $no_proxy"
+	npm config set no-proxy $no_proxy
+fi
+
 # Change the npm registry mirror if provided
 if [ ! -z "$NPM_MIRROR" ]; then
 	echo "---> Setting the npm package mirror to $NPM_MIRROR"