Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improved error handling #223

Merged
merged 2 commits into from
Apr 20, 2023
Merged

chore: improved error handling #223

merged 2 commits into from
Apr 20, 2023

Conversation

lance
Copy link
Member

@lance lance commented Apr 19, 2023

Improves the response when a user function throws an exception.

Improves the response when a user function throws an exception.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from lholmquist April 19, 2023 19:16
Signed-off-by: Lance Ball <lball@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.57 ⚠️

Comparison is base (54c7c85) 90.90% compared to head (6bfc9bd) 90.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   90.90%   90.34%   -0.57%     
==========================================
  Files           9        9              
  Lines         286      290       +4     
==========================================
+ Hits          260      262       +2     
- Misses         26       28       +2     
Impacted Files Coverage Δ
lib/invocation-handler.js 93.75% <100.00%> (+2.08%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance lance merged commit ef6bc77 into nodeshift:main Apr 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants