fix(config): add package name sanitisation (#212)

Attempting to deploy an application that fails to meet openshift's
naming rules will result in misleading error messages being returned.

This commit addresses the issue by verifying the package.name is
compliant with openshift's naming restrictions.

fix linter issues

remove wc file

remove added line

fixes #211

bin/nodeshift

@@ -112,7 +112,11 @@ function commandHandler (argv) {
   })
     .catch((err) => {
       log.error(err.message);
-      log.error('Status code', err.statusCode);
+
+      if (err && err.statusCode) {
+        log.error('Status code', err.statusCode);
+      }
+
       require('util').debuglog('nodeshift.cli')(err.stack);
       process.exit(1);
     });

lib/nodeshift-config.js

@@ -36,6 +36,10 @@ async function setup (options = {}) {
   const config = await openshiftConfigLoader(Object.assign({}, {tryServiceAccount: options.tryServiceAccount, configLocation: options.configLocation}));
   logger.info(`using namespace ${config.context.namespace} at ${config.cluster}`);
 
+  if (!projectPackage.name.match(/^[a-z][0-9a-z-]+[0-9a-z]$/)) {
+    throw new Error('"name" in package.json can only consist lower-case letters, numbers, and dashes. It must start with a letter and can\'t end with a -.');
+  }
+
   // Return a new object with the config, the rest client and other data.
   return Object.assign({}, config, {
     projectPackage,

test/nodeshift-config-test.js

@@ -96,6 +96,51 @@ test('nodeshift-config no package.json', (t) => {
   });
 });
 
+test('nodeshift-config invalid "name" in package.json', (t) => {
+  const nodeshiftConfig = proxyquire('../lib/nodeshift-config', {
+    'openshift-config-loader': () => {
+      return Promise.resolve({
+        context: {
+          namespace: 'test-namespace'
+        },
+        cluster: 'http://mock-cluster'
+      });
+    },
+    'openshift-rest-client': () => { return Promise.resolve({}); }
+  });
+
+  const tmpDir = require('os').tmpdir();
+  const join = require('path').join;
+  const fs = require('fs');
+
+  const options = {
+    projectLocation: join(tmpDir, 'nodeshift-invalid-package-name-test')
+  };
+
+  if (!fs.existsSync(options.projectLocation)) {
+    fs.mkdirSync(options.projectLocation);
+  }
+
+  // Create a temp package that has an invalid name, but extends the example JSON
+  fs.writeFileSync(
+    join(options.projectLocation, 'package.json'),
+    JSON.stringify(
+      Object.assign(
+        {},
+        require('../examples/sample-project/package.json'),
+        {
+          name: '@invalid-package-name'
+        }
+      )
+    )
+  );
+
+  nodeshiftConfig(options).catch((err) => {
+    t.equal(err.message.includes('"name" in package.json can only consist lower-case letters, numbers, and dashes. It must start with a letter and can\'t end with a -.'), true);
+    t.end();
+  });
+});
+
 test('nodeshift-config options for the config loader', (t) => {
   const nodeshiftConfig = proxyquire('../lib/nodeshift-config', {
     'openshift-config-loader': (options) => {