fix: add a name (http) to the service port (#218)

nodeshift · Apr 25, 2018 · c599dc0 · c599dc0
1 parent bd3f10b
commit c599dc0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/resource-enrichers/service-enricher.js b/lib/resource-enrichers/service-enricher.js
@@ -44,12 +44,12 @@ function defaultService (config) {
     provider: 'nodeshift'
   };
 
-  // TODO: verify the ports property/add the ports property if missing?
   serviceConfig.spec.ports = [
     {
       protocol: 'TCP',
       port: config.port,
-      targetPort: config.port
+      targetPort: config.port,
+      name: 'http'
     }
   ];
 

diff --git a/test/enricher-tests/service-enricher-test.js b/test/enricher-tests/service-enricher-test.js
@@ -70,5 +70,6 @@ test('service enricher test - service', async (t) => {
   t.ok(Array.isArray(se[0].spec.ports), 'ports prop should be here');
   t.ok(se[0].spec.type, 'type prop should be here');
   t.equal(se[0].spec.type, 'ClusterIP', 'spec.type should be ClusterIP');
+  t.equal(se[0].spec.ports[0].name, 'http');
   t.end();
 });