feat: Remove Watch command (#296)

BREAKING CHANGE: This removes the watch command

This feature was just wrapping the `oc rsync` command, which nodeshift probably shouldn't be doing.  It is better to just use that command instead

fixes #280

README.md

@@ -39,8 +39,6 @@ By default, if you run just `nodeshift`, it will run the `deploy` goal, which is
 
 **undeploy** - removes resources that were deployed with the apply-resource command
 
-**watch** - connect to a running pod.  Also watches your local files for changes to sync with the remote pod
-
 
 ### `.nodeshift` Directory
 
@@ -205,9 +203,6 @@ Shows the below help
             nodeshift resource        resource command
             nodeshift apply-resource  apply resource command
             nodeshift undeploy        undeploy resources
-            nodeshift watch           connect to running Pod and watch local
-                                      filesystem for changes to sync with
-                                      remote Pod
 
         Options:
             --version                Show version number                         [boolean]

bin/cli.js

@@ -23,7 +23,6 @@ const resourceGoal = require('../lib/goals/resource');
 const buildGoal = require('../lib/goals/build');
 const applyResources = require('../lib/goals/apply-resources');
 const undeployGoal = require('../lib/goals/undeploy');
-const watchSyncGoal = require('../lib/goals/watch-spawn');
 const namespace = require('../lib/namespace');
 
 /**
@@ -67,9 +66,6 @@ module.exports = async function run (options) {
         response.resources = await resourceGoal(config);
         response.appliedResources = await applyResources(config, response.resources);
         break;
-      case 'watch':
-        await watchSyncGoal(config);
-        break;
       default:
         throw new TypeError(`Unexpected command: ${options.cmd}`);
     }

bin/nodeshift

@@ -36,7 +36,6 @@ yargs
   .command('resource', 'resource command', { cmd: { default: 'resource' } }, commandHandler)
   .command('apply-resource', 'apply resource command', { cmd: { default: 'apply-resource' } }, commandHandler)
   .command('undeploy [removeAll]', 'undeploy resources', { cmd: { default: 'undeploy' } }, commandHandler)
-  .command('watch', 'watch resources', { cmd: { default: 'watch' } }, commandHandler)
   .option('projectLocation', {
     describe: 'change the default location of the project',
     type: 'string'

test/cli-test.js

@@ -261,38 +261,6 @@ test('build goal - with namespace', (t) => {
   });
 });
 
-test('watch goal', (t) => {
-  const cli = proxyquire('../bin/cli', {
-    '../lib/nodeshift-config': () => {
-      return Promise.resolve({});
-    },
-    '../lib/goals/resource': (config) => {
-      t.fail('should not be here for the watch goal');
-      return Promise.resolve();
-    },
-    '../lib/goals/build': (config) => {
-      t.fail('should not be here for the watch goal');
-      return Promise.resolve();
-    },
-    '../lib/goals/apply-resources': (config) => {
-      t.fail('should not be here for the watch goal');
-      return Promise.resolve();
-    },
-    '../lib/goals/undeploy': (config) => {
-      t.fail('should not be here for the watch goal');
-      return Promise.resolve();
-    },
-    '../lib/goals/watch-spawn': (config) => {
-      t.pass('should be here for the watch goal');
-      return Promise.resolve();
-    }
-  });
-
-  cli({ cmd: 'watch' }).then(() => {
-    t.end();
-  });
-});
-
 test('error', (t) => {
   const cli = proxyquire('../bin/cli', {
     '../lib/nodeshift-config': () => {