Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: projectLocation should be set correctly. #189

Merged
merged 1 commit into from
Feb 13, 2018
Merged

fix: projectLocation should be set correctly. #189

merged 1 commit into from
Feb 13, 2018

Conversation

lholmquist
Copy link
Member

  • If a projectLocation was overriden, it was not being used when checking for the files it should be loading. The archive creator was also not paying attention to the projectLocation property.

fixes #188

@ghost ghost assigned lholmquist Feb 13, 2018
@ghost ghost added the in progress label Feb 13, 2018
@coveralls
Copy link

coveralls commented Feb 13, 2018 •
edited

Coverage Status

Coverage remained the same at 95.81% when pulling 8da9190 on lholmquist:188-projectLocation-bug into e123bfb on bucharest-gold:master.

@lholmquist
fix: projectLocation should be set correctly.
8da9190 
* If a projectLocation was overriden, it was not being used when checking for the files it should be loading.  The archive creator was also not paying attention to the projectLocation property.

fixes nodeshift#188
@lholmquist lholmquist merged commit 4e061a9 into nodeshift:master Feb 13, 2018
@ghost ghost removed the in progress label Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lholmquist lholmquist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deployment works bad with config - projectLocation
2 participants
@lholmquist @coveralls