add package name sanitisation #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
evanshortiss
commented
Apr 6, 2018
test/nodeshift-config-test.js
Outdated
| 'openshift-rest-client': () => { return Promise.resolve({}); } | ||
| }); | ||
|
|
||
| const tmpDir = require('os').tmpdir() |
There was a problem hiding this comment.
Wasn't certain about creating an item in examples/ with an invalid name, so I took this approach instead. Happy to create a file in the repo if preferable.
|
@evanshortiss i was on PTO last week, so i'll get this today hopefully |
|
@lholmquist no sweat, it's a minor enough issue anyways! |
lholmquist
reviewed
Apr 9, 2018
lib/nodeshift-config.js
Outdated
| @@ -31,11 +31,16 @@ async function setup (options = {}) { | |||
| options.nodeshiftDirectory = '.nodeshift'; | |||
| options.projectLocation = options.projectLocation || process.cwd(); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
looks like a stray extra line here
|
other than that 1 comment, i think this should work. maybe just squash those commits into 1 |
Attempting to deploy an application that fails to meet openshift's naming rules will result in misleading error messages being returned. This commit addresses the issue by verifying the package.name is compliant with openshift's naming restrictions. fix linter issues remove wc file remove added line
evanshortiss
force-pushed
the
package-name-check
branch
from
46dead5
to
9f54b9a
Compare
|
@lholmquist think we should be good now 👍 |
|
released as 1.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to deploy an application that fails to meet openshift's
naming rules will result in misleading error messages being returned.
This commit addresses the issue by verifying the package.name is
compliant with openshift's naming restrictions.
See issue #211