Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a name (http) to the service port #218

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

lance
Copy link
Member

@lance lance commented Apr 25, 2018

I'm not sure if we should provide a configuration option for this or not. I'm also not sure what the behavior would be if some other value was already specified in a .nodeshift/service.yml file.

fixes #183

@lance lance self-assigned this Apr 25, 2018
@lance lance requested a review from lholmquist April 25, 2018 13:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.078% when pulling 2439540 on 183-add-name-to-service-port into bd3f10b on master.

@lholmquist
Copy link
Member

i would say we probably don't need this to be configurable, since it is really just a label(I think).

I think if someone had the ports section in a .nodeshift/service.yml it would merge it using the https://lodash.com/docs/4.17.5#merge function.

I'm not really clear on what the other protocols would be to have multiple ports, this was basically a copy/paste from another example.

@lance
Copy link
Member Author

lance commented Apr 25, 2018

@lholmquist I think this is really just a name, so that if a service has multiple ports they can be disambiguated within a route. I'm going to go ahead and merge this.

@lance lance merged commit c599dc0 into master Apr 25, 2018
@ghost ghost removed the in progress label Apr 25, 2018
@lholmquist lholmquist deleted the 183-add-name-to-service-port branch January 15, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service port should have a name
3 participants