feat: add the namespace flag #234
Conversation
ghost
assigned 
|
@deewhyweb i think that might do it, mind giving a try |
This would actually be great. And removing the project will remove all of the various pods that are a part of it, in one fell swoop. |
bin/nodeshift
Outdated
| @@ -74,6 +74,10 @@ yargs | |||
| type: 'boolean', | |||
| default: false | |||
| }) | |||
| .options('namespace', { | |||
| describe: 'flag to specify the project namespace to build/deploy into. Overwrites the value from the config loader', | |||
There was a problem hiding this comment.
Does it make more sense to say something like, "Overwrites any namespace settings in your OpenShift of Kubernetes configuration files"? Not sure that's an improvement, but saying "the config loader" implies knowledge of nodeshift that the user might not have.
There was a problem hiding this comment.
that makes sense. will change
This allows the user to specify a namespace project during the build/deploy. Overwrites any namespace settings in your OpenShift or Kubernetes configuration files fixes nodeshift#233
lholmquist
force-pushed
the
233-specify-namespace
branch
from
4339d8f
to
c78337e
Compare
|
I'll give it a go today.
…On Fri, Jun 1, 2018 at 11:38 AM, Lucas Holmquist ***@***.***> wrote:
@deewhyweb <https://github.com/deewhyweb> i think that might do it, mind
giving a try
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#234 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKd5H1pK0wr3ScurdECFnSNOD6ld2maks5t4V_ggaJpZM4UW5zM>
.
|
|
@deewhyweb thanks, i didn't actually do a new release yet. |
This allows the user to specify a namespace project during the build/deploy. Overrides the namespace that the config loader gets
fixes #233
This should do it. I am curios though, how easy would it be to have the project get created if the namespace that was specified didn't exist yet. probably could be another PR though
That could be interesting for Rhoaster, like, you deploy your app to a "temporary" namespace that gets created, then during the undeploy, it can get remove(or keep it around if you wanted to)