Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a namespace/project if one doesn't exist when using the --namespace flag #275

Merged
merged 8 commits into from
Feb 1, 2019
Merged

Create a namespace/project if one doesn't exist when using the --namespace flag #275

merged 8 commits into from
Feb 1, 2019

Conversation

lholmquist
Copy link
Member

@lholmquist lholmquist commented Jan 14, 2019 •
edited

connects to #235

@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited

Pull Request Test Coverage Report for Build 692

  • 37 of 37 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 95.798%
Totals Coverage Status
Change from base Build 688: 0.6%
Covered Lines: 663
Relevant Lines: 698
💛 - Coveralls

@lholmquist lholmquist changed the title WIP - 235 create namespace Create a namespace/project if one doesn't exist when using the --namespace flag Jan 25, 2019
lance
lance approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lholmquist lholmquist merged commit 202d71b into nodeshift:master Feb 1, 2019
@lholmquist lholmquist removed the review label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@helio-frota helio-frota helio-frota approved these changes

@danbev danbev Awaiting requested review from danbev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lholmquist @coveralls @lance @helio-frota