Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the --no-perm=true option to the oc rsync command #277

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix: add the --no-perm=true option to the oc rsync command #277

merged 1 commit into from
Jan 21, 2019

Conversation

lholmquist
Copy link
Member

fixes #274

@lance if you wouldn't mind giving this a little test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.174%
Totals Coverage Status
Change from base Build 680: 0.0%
Covered Lines: 626
Relevant Lines: 663
💛 - Coveralls

@lholmquist lholmquist requested a review from lance January 16, 2019 13:54
lance
lance approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I haven't tested it yet, but should be able to give it a try today.

@lholmquist lholmquist merged commit b4695c6 into nodeshift:master Jan 21, 2019
@lholmquist lholmquist removed the review label Jan 21, 2019
@lholmquist lholmquist deleted the 274_no-perm branch January 21, 2019 16:06
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodeshift --watch fails to set permissions on remote directory
3 participants
@lholmquist @coveralls @lance