Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: namespace.name spelling/parsing error #283

Merged
merged 2 commits into from
Feb 4, 2019
Merged

fix: namespace.name spelling/parsing error #283

merged 2 commits into from
Feb 4, 2019

Conversation

evanshortiss
Copy link
Contributor

Simple one, but caught me out by deploying my project into the wrong namespace 馃槅

@coveralls
Copy link

coveralls commented Feb 2, 2019 •
edited

Pull Request Test Coverage Report for Build 696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.798%
Totals Coverage Status
Change from base Build 694: 0.0%
Covered Lines: 663
Relevant Lines: 698
馃挍 - Coveralls

@lholmquist
Copy link
Member

@evanshortiss LGTM, can you just remove the version update. i'll take care of that when i run npm run release

@evanshortiss
Copy link
Contributor Author

@lholmquist will update shortly 馃憤

@lholmquist lholmquist merged commit afb2a64 into nodeshift:master Feb 4, 2019
@lholmquist lholmquist removed the review label Feb 4, 2019
@lholmquist
Copy link
Member

should be on npm now as 2.1.1

@snyk-bot snyk-bot mentioned this pull request May 15, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanshortiss @coveralls @lholmquist