Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove Watch command #296

Merged
merged 1 commit into from
Mar 25, 2019
Merged

chore: Remove Watch command #296

merged 1 commit into from
Mar 25, 2019

Conversation

helio-frota
Copy link
Member

Connects to #280

@coveralls
Copy link

Pull Request Test Coverage Report for Build 738

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.07%) to 96.872%
Totals Coverage Status
Change from base Build 719: 1.07%
Covered Lines: 630
Relevant Lines: 653
💛 - Coveralls

lholmquist
lholmquist approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

I think this should probably be a semver major change since we are removing a feature. I'll updated the commit message when i merge it

@lholmquist lholmquist merged commit fa79166 into nodeshift:master Mar 25, 2019
@lholmquist lholmquist removed the review label Mar 25, 2019
@helio-frota helio-frota deleted the nodeshift-280 branch March 25, 2019 13:21
@lholmquist lholmquist mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@helio-frota @coveralls @lholmquist