Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BREAKING CHANGE: remove the nodeVersion flag. #298

Merged
merged 1 commit into from
Mar 25, 2019
Merged

feat: BREAKING CHANGE: remove the nodeVersion flag. #298

merged 1 commit into from
Mar 25, 2019

Conversation

lholmquist
Copy link
Member

  • This has been marked as deprecated in 1.x and can be removed.

fixes #281

@lholmquist
feat: BREAKING CHANGE: remove the nodeVersion flag.
c43ee0e 
* This has been marked as deprecated in 1.x and can be removed.

fixes nodeshift#281
@coveralls
Copy link

Pull Request Test Coverage Report for Build 742

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 96.872%
Totals Coverage Status
Change from base Build 741: -0.007%
Covered Lines: 630
Relevant Lines: 653
💛 - Coveralls

@lholmquist lholmquist merged commit 1c104ff into nodeshift:master Mar 25, 2019
@lholmquist lholmquist removed the review label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the nodeVersion flag
2 participants
@lholmquist @coveralls