Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the string version of the namespace flag #299

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

lholmquist
Copy link
Member

Just doing --namespace=name has been deprecated for a while and needs to be removed.

It is recommended to use the format --namespace.name

connects to #282

*BREAKING CHANGE: remove the string option for namespace creation.  This has been deprecated and it is now time to remove it

fixes nodeshift#282
@coveralls
Copy link

Pull Request Test Coverage Report for Build 744

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 96.811%

Totals Coverage Status
Change from base Build 743: -0.06%
Covered Lines: 621
Relevant Lines: 644

💛 - Coveralls

@lholmquist lholmquist merged commit 5674b89 into nodeshift:master Mar 27, 2019
@lholmquist lholmquist removed the review label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants