-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding web-app flag #395
Adding web-app flag #395
Conversation
Pull Request Test Coverage Report for Build 1050
💛 - Coveralls |
looking pretty good, and for the test, you should be able to copy something from https://github.com/nodeshift/nodeshift/blob/master/test/build-strategy-test.js or https://github.com/nodeshift/nodeshift/blob/master/test/definitions-tests/build-strategy-test.js which just realized should be merged together. I'll create another issue for that |
@lholmquist I finished writing the tests (It's just a single test though). I think the PR is ready for a final review and merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@alexalikiotis since we merged #397, the test file you added your tests to doesn't exist anymore :) can you rebase this PR with master. |
@lholmquist Done! |
I'm re-opening the PR from the new branch 'web-app-flag'. Still WIP but the linting error is fixed and I also updated the docs, so the only thing left is writing the tests :)