Update to latest Openshift Rest Client #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The api for the openshift rest client has changed slightly, but there should be no nodeshift api changes While this doesn't have to be a semver-major release, there might be some unexpected bugs. One known issue, is we are no longer passing a custom config to the rest client. If this removal causes issues we can work on a way to put it back in fixes nodeshift#377
Pull Request Test Coverage Report for Build 1054
💛 - Coveralls |
helio-frota
approved these changes
Jan 15, 2020
aalykiot
approved these changes
Jan 15, 2020
This was referenced Mar 25, 2020
This was referenced Apr 6, 2020
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove deprecation warnings from openshift rest client
BREAKING CHANGE: The api for the openshift rest client has changed slightly, but there should be no nodeshift api changes
While this doesn't have to be a semver-major release, there might be some unexpected bugs. One known issue, is we are no longer passing a custom config to the rest client. If this removal causes issues we can work on a way to put it back in
fixes #377
fixes #375