Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine parameter targets node 10+ #406

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Engine parameter targets node 10+ #406

merged 1 commit into from
Jan 31, 2020

Conversation

aalykiot
Copy link
Member

@lholmquist this PR changes the node's engine version from 8+ to 10+. Do I also have to do the release process for the semver-major update we talked about and add it in this PR or you'll do it after the PR merge ??

@coveralls
Copy link

coveralls commented Jan 31, 2020

Pull Request Test Coverage Report for Build 1080

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.674%

Totals Coverage Status
Change from base Build 674: 0.0%
Covered Lines: 641
Relevant Lines: 666

💛 - Coveralls

@lholmquist
Copy link
Member

Do I also have to do the release process for the semver-major update we talked about and add it in this PR or you'll do it after the PR merge ??

we will do that once the PR is merged and we do a release

@lholmquist lholmquist marked this pull request as ready for review January 31, 2020 14:20
@lholmquist lholmquist merged commit c820b80 into nodeshift:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants