feat(build-strategy): Add Docker build strategy #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This adds a new flag `build.strategy` which takes the values Docker or Source. default to Source. * Source will build with an s2i image, while Docker will use the Dockerfile from the application to build.
lholmquist
requested review from
aalykiot,
helio-frota,
lance,
danbev and
a team
and removed request for
a team
aalykiot
approved these changes
May 12, 2020
helio-frota
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag
build.strategywhich takes the values Docker or Source. default to Source.Source will build with an s2i image, while Docker will use the Dockerfile from the application to build.
To use the Docker strat, you would do
npx nodeshift --build.strategy=DockerFor testing this out, i've been using CRC, and this sample dockerized node app, https://github.com/nodeshift-starters/basic-node-app-dockerized