Knative Serving Deployment #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deshift directory
lholmquist
force-pushed
the
knative-serving-fuckery
branch
from
eb7ac04
to
bf81c4f
Compare
|
i know there is a lot to review here, but i'm adding this feature as experimental, so we can get it in and then iterate on it |
|
@lance i think I addressed the nits |
|
@lance looks like i got them all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to add the ability for nodeshift to deploy a knative serving service.
It is a work in progress, but the happy path works here.
using the nodejs-rest-http starter and code ready containers with the serverless operator installed and setup. i was able to do
nodeshift --knative=truewith out having to change the starter app.For a deploy, the first part(build) is unchanged, the "apply-resource" part, which is the second phase of a nodeshift deploy, has been updated to only create a knative serving service that points to the image that was just built in the first step.
If an application has a
.nodeshiftdirectory with resource files that are not related to knative, they are ignored