Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Node.js 12 #652

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: drop Node.js 12 #652

merged 1 commit into from
Feb 1, 2023

Conversation

BethGriggs
Copy link
Contributor

This would require a semver major bump so may want to time landing/releasing appropriately.

@richardlau
Copy link

richardlau commented Jul 1, 2022 •
edited

This would require a semver major bump so may want to time landing/releasing appropriately.

In which case, maybe the commit title should be

chore!: drop Node.js 12

? https://www.conventionalcommits.org/en/v1.0.0/
(or https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer with an example with ! and the BREAKING CHANGE: footer)

mhdawson
mhdawson approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Richards suggestion for the commit comment

@lholmquist lholmquist merged commit 49cf11f into nodeshift:main Feb 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 1, 2023
Closed
@github-actions github-actions bot mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BethGriggs @richardlau @mhdawson @lholmquist